Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] #266

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 6, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin v0.42.0 -> v0.44.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2023-45142

Summary

This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels

  • http.user_agent
  • http.method

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.

Details

HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.

PoC

Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.

Others

It is similar to already reported vulnerabilities

Workaround for affected versions

As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.

For convenience and safe usage of this library, it should by default mark with the label unknown non-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.

The other possibility is to disable HTTP metrics instrumentation by passing otelhttp.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute http.request.method were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.

References

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Aug 6, 2024 •
edited
Loading

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -d -t ./...
go: -d flag is deprecated. -d=true is a no-op
go: downloading github.com/jmoiron/sqlx v1.3.5
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/spf13/cobra v1.7.0
go: downloading github.com/spf13/viper v1.16.0
go: downloading go.hollow.sh/toolbox v0.6.1
go: downloading go.infratographer.com/x v0.3.7
go: downloading go.uber.org/zap v1.25.0
go: downloading gocloud.dev v0.33.0
go: downloading github.com/cockroachdb/cockroach-go/v2 v2.3.5
go: downloading github.com/gosimple/slug v1.13.1
go: downloading github.com/lib/pq v1.10.9
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/stretchr/testify v1.8.4
go: downloading github.com/volatiletech/null/v8 v8.1.2
go: downloading github.com/volatiletech/sqlboiler/v4 v4.15.0
go: downloading github.com/volatiletech/null v8.0.0+incompatible
go: downloading github.com/volatiletech/sqlboiler v3.7.1+incompatible
go: downloading github.com/gin-contrib/cors v1.4.0
go: downloading github.com/thinkgos/zap v0.0.2-0.20210226022008-5b2cf0c4d297
go: downloading github.com/gin-gonic/gin v1.9.1
go: downloading github.com/zsais/go-gin-prometheus v0.1.0
go: downloading go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin v0.44.0
go: downloading go.opentelemetry.io/otel v1.18.0
go: downloading github.com/friendsofgo/errors v0.9.2
go: downloading github.com/volatiletech/strmangle v0.0.5
go: downloading github.com/volatiletech/randomize v0.0.1
go: downloading github.com/google/uuid v1.3.1
go: downloading golang.org/x/exp v0.0.0-20230817173708-d852ddb80c63
go: downloading gopkg.in/square/go-jose.v2 v2.6.0
go: downloading github.com/fsnotify/fsnotify v1.6.0
go: downloading github.com/mitchellh/mapstructure v1.5.0
go: downloading github.com/spf13/afero v1.9.5
go: downloading github.com/spf13/cast v1.5.1
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/inconshreveable/mousetrap v1.1.0
go: downloading golang.org/x/net v0.15.0
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/nats-io/nats.go v1.28.0
go: downloading github.com/XSAM/otelsql v0.23.0
go: downloading go.opentelemetry.io/otel/exporters/jaeger v1.16.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.16.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.16.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.16.0
go: downloading go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.16.0
go: downloading go.opentelemetry.io/otel/sdk v1.16.0
go: downloading github.com/pressly/goose/v3 v3.15.0
go: downloading go.uber.org/multierr v1.11.0
go: downloading golang.org/x/crypto v0.13.0
go: downloading github.com/gosimple/unidecode v1.0.1
go: downloading github.com/jackc/pgx/v4 v4.18.1
go: downloading github.com/ericlagergren/decimal v0.0.0-20221120152707-495c53812d05
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/gin-contrib/sse v0.1.0
go: downloading github.com/mattn/go-isatty v0.0.19
go: downloading github.com/prometheus/client_golang v1.16.0
go: downloading github.com/sirupsen/logrus v1.9.3
go: downloading go.opentelemetry.io/otel/trace v1.18.0
go: downloading golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
go: downloading github.com/volatiletech/inflect v0.0.1
go: downloading github.com/gofrs/uuid v4.4.0+incompatible
go: downloading github.com/go-logr/logr v1.2.4
go: downloading go.opentelemetry.io/otel/metric v1.18.0
go: downloading golang.org/x/sys v0.12.0
go: downloading golang.org/x/text v0.13.0
go: downloading github.com/subosito/gotenv v1.6.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading gopkg.in/ini.v1 v1.67.0
go: downloading github.com/magiconair/properties v1.8.7
go: downloading github.com/pelletier/go-toml/v2 v2.0.9
go: downloading github.com/hashicorp/errwrap v1.1.0
go: downloading github.com/klauspost/compress v1.16.7
go: downloading github.com/nats-io/nkeys v0.4.4
go: downloading github.com/nats-io/nuid v1.0.1
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading go.opentelemetry.io/proto/otlp v1.0.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.16.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20230815205213-6bfd019c3878
go: downloading google.golang.org/genproto v0.0.0-20230815205213-6bfd019c3878
go: downloading google.golang.org/grpc v1.57.0
go: downloading google.golang.org/protobuf v1.31.0
go: downloading go.opencensus.io v0.24.0
go: downloading github.com/jackc/pgconn v1.14.1
go: downloading github.com/jackc/pgio v1.0.0
go: downloading github.com/jackc/pgproto3/v2 v2.3.2
go: downloading github.com/jackc/pgtype v1.14.0
go: downloading github.com/go-playground/validator/v10 v10.15.0
go: downloading github.com/ugorji/go/codec v1.2.11
go: downloading github.com/bytedance/sonic v1.10.0
go: downloading github.com/goccy/go-json v0.10.2
go: downloading github.com/json-iterator/go v1.1.12
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/prometheus/client_model v0.4.0
go: downloading github.com/prometheus/common v0.44.0
go: downloading github.com/prometheus/procfs v0.11.1
go: downloading github.com/cenkalti/backoff/v4 v4.2.1
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.16.2
go: downloading github.com/golang/protobuf v1.5.3
go: downloading github.com/googleapis/gax-go/v2 v2.12.0
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading github.com/jackc/chunkreader/v2 v2.0.1
go: downloading github.com/jackc/pgpassfile v1.0.0
go: downloading github.com/jackc/pgservicefile v0.0.0-20221227161230-091c0ba34f0a
go: downloading github.com/gabriel-vasile/mimetype v1.4.2
go: downloading github.com/go-playground/universal-translator v0.18.1
go: downloading github.com/leodido/go-urn v1.2.4
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20230815205213-6bfd019c3878
go: downloading google.golang.org/api v0.137.0
go: downloading github.com/go-playground/locales v0.14.1
go: downloading github.com/chenzhuoyu/base64x v0.0.0-20230717121745-296ad89f973d
go: downloading golang.org/x/arch v0.4.0
go: downloading github.com/klauspost/cpuid/v2 v2.2.5
go: downloading github.com/twitchyliquid64/golang-asm v0.15.1
go: downloading github.com/chenzhuoyu/iasm v0.9.0
go: downloading go.opentelemetry.io v0.1.0
go: downloading go.opentelemetry.io/otel/exporters/otlp v0.20.1
go: downloading go.opentelemetry.io/otel v1.31.0
go: go.hollow.sh/serverservice/cmd imports
	go.infratographer.com/x/otelx imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace imports
	go.opentelemetry.io/otel/exporters/otlp/internal: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal
go: go.hollow.sh/serverservice/cmd imports
	go.infratographer.com/x/otelx imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
	go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: cannot find module providing package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

@renovate renovate bot requested a review from a team as a code owner August 6, 2024 10:30
@renovate renovate bot changed the title fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] - autoclosed Nov 5, 2024
@renovate renovate bot closed this Nov 5, 2024
@renovate renovate bot deleted the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-gin-gonic-gin-otelgin-vulnerability branch November 5, 2024 23:09
@renovate renovate bot changed the title fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] - autoclosed fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] Nov 6, 2024
@renovate renovate bot restored the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-gin-gonic-gin-otelgin-vulnerability branch November 6, 2024 01:38
@renovate renovate bot reopened this Nov 6, 2024
@renovate
fix(deps): update module go.opentelemetry.io/contrib/instrumentation/…
09edcda 
…github.com/gin-gonic/gin/otelgin to v0.44.0 [security]
@renovate renovate bot force-pushed the renovate/go-go.opentelemetry.io-contrib-instrumentation-github.com-gin-gonic-gin-otelgin-vulnerability branch from c5dbf6c to 09edcda Compare November 6, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants